ElixirForge/SunGather
3
0
Fork 0
mirror of https://github.com/alexhopeoconnor/SunGather.git synced 2026-10-23 11:02:10 +10:00
Code Issues Packages Projects Releases Wiki Activity

v0.3.3: Fix unsigned/signed registers to allow negative values

Browse Source
This commit is contained in:
bohdan-s
2022-03-03 12:59:46 +11:00
parent 75f0c354f2
commit 0a9004dc21
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SunGather/sungather.py
+11 -15
View File
@@ -200,12 +200,16 @@ class SungrowInverter():
if register_type == register['type'] and register['address'] == run: if register_type == register['type'] and register['address'] == run:
register_name = register['name'] register_name = register['name']
register_value = None register_value = rr.registers[num]
# Return the 32bit value if needed
if register.get('datatype') == "U32" or register.get('datatype') == "S32": # Convert unsigned to signed
if register.get('datatype') == "S32":
u32_value = rr.registers[num+1] u32_value = rr.registers[num+1]
if u32_value and register_value: if u32_value == 65535: # Flag to say value is negative for 32bit
register_value = (u32_value * 65535) + register_value register_value = (register_value - 65535)
elif register.get('datatype') == "S16":
if register_value >= 32767: # Anything greater than 32767 is a negative for 16bit
register_value = (register_value - 65535)
# We convert a system response to a human value # We convert a system response to a human value
if register.get('datarange'): if register.get('datarange'):
@@ -215,16 +219,8 @@ class SungrowInverter():
if not register_value: if not register_value:
register_value = rr.registers[num] register_value = rr.registers[num]
# Adjust the value if needed # If xFF / xFFFF then change to 0, looks better when logging / graphing
if register.get('indicator'): if register_value == 65535:
indicator_value = rr.registers[num+1]
if indicator_value == 65535:
register_value = -1 * (65535 - register_value)
# If xFF (U 65535 / S 32767) then change to 0, looks better when logging / graphing
if register.get('datatype') == 'S16' and (register_value == 32767 or register_value == 65535):
register_value = 0
elif (register.get('datatype') == 'U16' or register.get('datatype') == 'S32' or register.get('datatype') == 'U32') and register_value == 65535:
register_value = 0 register_value = 0
if register.get('accuracy'): if register.get('accuracy'):