From 276795079e2f463837e51689b05bc5f8b99acf4f Mon Sep 17 00:00:00 2001 From: Shawn A Date: Wed, 9 Mar 2016 16:03:51 -0600 Subject: [PATCH 1/2] add remove duplicate ap feature fixes #26 --- WiFiManager.cpp | 47 ++++++++++++++++++++++++++++++----------------- WiFiManager.h | 3 ++- 2 files changed, 32 insertions(+), 18 deletions(-) diff --git a/WiFiManager.cpp b/WiFiManager.cpp index 25f5823..fa4255a 100644 --- a/WiFiManager.cpp +++ b/WiFiManager.cpp @@ -390,37 +390,50 @@ void WiFiManager::handleWifi(boolean scan) { DEBUG_WM(F("No networks found")); page += F("No networks found. Refresh to scan again."); } else { + //sort networks - /*int indices[n]; - - for (int i = 0; i < n; i++) { - indices[i] = i; - } - - for (int i = 0; i < n; i++) { - for (int j = i + 1; j < n; j++) { - if (WiFi.RSSI(indices[j]) > WiFi.RSSI(indices[i])) { - //int temp = indices[j]; - //indices[j] = indices[i]; - //indices[i] = temp; - std::swap(indices[i], indices[j]); - } - } - } - */ int indices[n]; for (int i = 0; i < n; i++) { indices[i] = i; } + // RSSI SORT + + // old sort + // for (int i = 0; i < n; i++) { + // for (int j = i + 1; j < n; j++) { + // if (WiFi.RSSI(indices[j]) > WiFi.RSSI(indices[i])) { + // //int temp = indices[j]; + // //indices[j] = indices[i]; + // //indices[i] = temp; + // std::swap(indices[i], indices[j]); + // } + // } + // } + std::sort(indices, indices + n, [](const int & a, const int & b) -> bool { return WiFi.RSSI(a) > WiFi.RSSI(b); }); + // remove duplicates ( must be RSSI sorted ) + if(_removeDupAps){ + String cssid; + for (int i = 0; i < n; i++) { + if(indices[i] == -1) continue; + cssid = WiFi.SSID(indices[i]); + for (int j = i + 1; j < n; j++) { + if(cssid == WiFi.SSID(indices[j])){ + DEBUG_WM("DUP AP: " + WiFi.SSID(indices[j])); + indices[j] = -1; // set dup aps to index -1 + } + } + } + } //display networks in page for (int i = 0; i < n; i++) { + if(indices[i] == -1) continue; // skip dups DEBUG_WM(WiFi.SSID(indices[i])); DEBUG_WM(WiFi.RSSI(indices[i])); int quality = getRSSIasQuality(WiFi.RSSI(indices[i])); diff --git a/WiFiManager.h b/WiFiManager.h index 0902e86..ed3f026 100644 --- a/WiFiManager.h +++ b/WiFiManager.h @@ -119,7 +119,7 @@ class WiFiManager //const int WM_DONE = 0; //const int WM_WAIT = 10; - //const String HTTP_HEAD = "{v}"; + //const Srting HTTP_HEAD = "{v}"; void setupConfigPortal(); void startWPS(); @@ -141,6 +141,7 @@ class WiFiManager int _paramsCount = 0; int _minimumQuality = -1; + boolean _removeDupAps = true; boolean _shouldBreakAfterConfig = false; boolean _tryWPS = false; From 745c3a91fd94e0748aed051b543b9c9fd0a5eb48 Mon Sep 17 00:00:00 2001 From: Shawn A Date: Wed, 9 Mar 2016 16:13:16 -0600 Subject: [PATCH 2/2] typo, shrug --- WiFiManager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WiFiManager.h b/WiFiManager.h index ed3f026..8848a8e 100644 --- a/WiFiManager.h +++ b/WiFiManager.h @@ -119,7 +119,7 @@ class WiFiManager //const int WM_DONE = 0; //const int WM_WAIT = 10; - //const Srting HTTP_HEAD = "{v}"; + //const String HTTP_HEAD = "{v}"; void setupConfigPortal(); void startWPS();