From 5730ce351a9403ac88464a1ec61ef7ac81edd519 Mon Sep 17 00:00:00 2001 From: Shawn A Date: Wed, 14 Feb 2018 22:36:36 -0600 Subject: [PATCH 1/3] left in debug --- WiFiManager.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/WiFiManager.cpp b/WiFiManager.cpp index aa4dbf2..2568b44 100644 --- a/WiFiManager.cpp +++ b/WiFiManager.cpp @@ -91,9 +91,9 @@ bool WiFiManager::addParameter(WiFiManagerParameter *p) { _max_params += WIFI_MANAGER_MAX_PARAMS; DEBUG_WM(F("Updated _max_params:"),_max_params); WiFiManagerParameter** new_params = (WiFiManagerParameter**)realloc(_params, _max_params * sizeof(WiFiManagerParameter*)); - DEBUG_WM(WIFI_MANAGER_MAX_PARAMS); - DEBUG_WM(_paramsCount); - DEBUG_WM(_max_params); + // DEBUG_WM(WIFI_MANAGER_MAX_PARAMS); + // DEBUG_WM(_paramsCount); + // DEBUG_WM(_max_params); if (new_params != NULL) { _params = new_params; } else { From 25b880cf9bb2dc50a387c9e8166432a59f32696a Mon Sep 17 00:00:00 2001 From: Shawn A Date: Wed, 14 Feb 2018 22:39:56 -0600 Subject: [PATCH 2/3] comments --- WiFiManager.cpp | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/WiFiManager.cpp b/WiFiManager.cpp index 2568b44..028378b 100644 --- a/WiFiManager.cpp +++ b/WiFiManager.cpp @@ -12,7 +12,11 @@ #include "WiFiManager.h" -// PARAMETERS +/** + * -------------------------------------------------------------------------------- + * WiFIManagerParameter + * -------------------------------------------------------------------------------- +**/ WiFiManagerParameter::WiFiManagerParameter(const char *custom) { _id = NULL; @@ -107,6 +111,12 @@ bool WiFiManager::addParameter(WiFiManagerParameter *p) { return true; } +/** + * -------------------------------------------------------------------------------- + * WiFIManager + * -------------------------------------------------------------------------------- +**/ + // constructors WiFiManager::WiFiManager(Stream& consolePort):_debugPort(consolePort) { WiFiManager(); @@ -118,6 +128,7 @@ WiFiManager::WiFiManager():_debugPort(Serial) { WiFi.persistent(false); // disable persistent so scannetworks and mode switching do not cause overwrites //parameters + // @todo belongs to wifimanagerparameter _max_params = WIFI_MANAGER_MAX_PARAMS; _params = (WiFiManagerParameter**)malloc(_max_params * sizeof(WiFiManagerParameter*)); } @@ -128,10 +139,12 @@ WiFiManager::~WiFiManager() { WiFi.mode(_usermode); // parameters + // @todo belongs to wifimanagerparameter if (_params != NULL){ DEBUG_WM(F("freeing allocated params!")); free(_params); } + DEBUG_WM(F("unloading")); } From a6dc373f5c287ad315820ef291f6c7d410fc9800 Mon Sep 17 00:00:00 2001 From: Shawn A Date: Wed, 14 Feb 2018 22:41:06 -0600 Subject: [PATCH 3/3] typo --- WiFiManager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WiFiManager.cpp b/WiFiManager.cpp index 028378b..bd5391d 100644 --- a/WiFiManager.cpp +++ b/WiFiManager.cpp @@ -14,7 +14,7 @@ /** * -------------------------------------------------------------------------------- - * WiFIManagerParameter + * WiFiManagerParameter * -------------------------------------------------------------------------------- **/ @@ -113,7 +113,7 @@ bool WiFiManager::addParameter(WiFiManagerParameter *p) { /** * -------------------------------------------------------------------------------- - * WiFIManager + * WiFiManager * -------------------------------------------------------------------------------- **/