ElixirForge/WiFiManager
1
0
Fork 0
mirror of https://github.com/alexhopeoconnor/WiFiManager.git synced 2026-10-14 23:21:31 +10:00
Code Releases Activity

Refactored to use only a default constructor and automatically resize the parameter array each time the size limit is reached.

Browse Source 
I used the initial size (WIFI_MANAGER_MAX_PARAMS) as the increment when resizing.
Existing data is coppied to the new array and the old one is free'd.
This commit is contained in:
Chris Liebman
2017-10-26 15:23:47 -07:00
parent 33704176e0
commit 6465d72f6e
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
WiFiManager.cpp
+12 -9
View File
@@ -61,10 +61,8 @@ const char* WiFiManagerParameter::getCustomHTML() {
}
WiFiManager::WiFiManager(int max_params) {
DEBUG_WM(F("setting max_params to:"));
DEBUG_WM(max_params);
_max_params = max_params;
WiFiManager::WiFiManager() {
_max_params = WIFI_MANAGER_MAX_PARAMS;
_params = (WiFiManagerParameter**)malloc(_max_params * sizeof(WiFiManagerParameter*));
}
@@ -80,12 +78,17 @@ WiFiManager::~WiFiManager()
void WiFiManager::addParameter(WiFiManagerParameter *p) {
if(_paramsCount + 1 > _max_params)
{
//Max parameters exceeded!
DEBUG_WM("max_params value exceeded, use WiFiManager(int max_params) constructor with a larger value!");
DEBUG_WM("Skipping parameter with ID:");
DEBUG_WM(p->getID());
return;
// rezise the params array
_max_params += WIFI_MANAGER_MAX_PARAMS;
DEBUG_WM(F("Increasing _max_params to:"));
DEBUG_WM(_max_params);
WiFiManagerParameter** new_params = (WiFiManagerParameter**)malloc(_max_params * sizeof(WiFiManagerParameter*));
// copy old data
memcpy(new_params, _params, _paramsCount * sizeof(WiFiManagerParameter*));
free(_params);
_params = new_params;
}
_params[_paramsCount] = p;
_paramsCount++;
DEBUG_WM("Adding parameter");