ElixirForge/WiFiManager
1
0
Fork 0
mirror of https://github.com/alexhopeoconnor/WiFiManager.git synced 2026-10-16 16:01:36 +10:00
Code Releases Activity

param was using user length for strncpy, causing overflows

Browse Source
This commit is contained in:
tablatronix
2018-07-13 23:43:07 -05:00
parent abbc110656
commit 933f86720a
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
WiFiManager.cpp
+6 -1
View File
@@ -63,12 +63,17 @@ WiFiManagerParameter::~WiFiManagerParameter() {
void WiFiManagerParameter::setValue(const char *defaultValue, int length) {
_length = length;
length = strlen(defaultValue); // length actual
if(_length < length){
// Serial.println("defaultValue length mismatch");
}
_value = new char[length + 1];
for (int i = 0; i < length + 1; i++) {
_value[i] = 0;
}
if (defaultValue != NULL) {
strncpy(_value, defaultValue, length + 1); // length+1 due to null terminated string
strncpy(_value, defaultValue, length);
_value[length] = '\0'; // explicit null
}
}
const char* WiFiManagerParameter::getValue() {