ElixirForge/bom-local-service
1
0
Fork 0
mirror of https://github.com/alexhopeoconnor/bom-local-service.git synced 2026-10-22 13:07:49 +10:00
Code Releases 7 Activity

Remove minutes ago parsing, use UTC timestamps directly

Browse Source 
- Refactor TimeParsingService to parse time strings to UTC only
- Remove minutesAgo from RadarFrame and FrameMetadata models
- Update CaptureFramesStep to extract UTC timestamps directly
- Update CacheService to store/load ObservationTime instead of MinutesAgo
- Update BomRadarService to use AbsoluteObservationTime directly
- Remove all backward compatibility code for old cache folders
- Update documentation and test SPA to calculate minutes ago on client
- Fix step registration to register concrete types for DI resolution
- Fix hosted service registration to use reflection correctly
This commit is contained in:
alex
2025-12-23 21:52:42 +10:00
parent b30d76ddec
commit ffd3636d1c
31 changed files with 598 additions and 372 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Views/RadarTest/Index.cshtml
+39 -25
View File
@@ -1222,32 +1222,37 @@
});
});
// Filter out frames without absoluteObservationTime (backend should have filtered these, so this catches bugs)
const invalidFrames = allFrames.filter((frame, idx) => !frame.absoluteObservationTime);
if (invalidFrames.length > 0) {
console.error('Backend returned frames missing absoluteObservationTime (should have been filtered):', {
count: invalidFrames.length,
frames: invalidFrames.map((f, idx) => ({
index: idx,
frameIndex: f.frameIndex,
cacheFolder: f.cacheFolderName,
imageUrl: f.imageUrl
}))
});
}
const validFrames = allFrames.filter(frame => frame.absoluteObservationTime);
// Validate chronological order to detect backend issues
let previousTime = null;
const outOfOrderFrames = [];
allFrames.forEach((frame, idx) => {
if (frame.absoluteObservationTime) {
const currentTime = new Date(frame.absoluteObservationTime).getTime();
if (previousTime !== null && currentTime < previousTime) {
outOfOrderFrames.push({
index: idx,
frameIndex: frame.frameIndex,
cacheFolder: frame.cacheFolderName,
absoluteTime: frame.absoluteObservationTime,
previousTime: new Date(previousTime).toISOString(),
timeDiffMinutes: (currentTime - previousTime) / 1000 / 60
});
}
previousTime = currentTime;
} else {
// Missing absoluteObservationTime is also an issue
console.warn(`Frame at index ${idx} missing absoluteObservationTime`, {
validFrames.forEach((frame, idx) => {
const currentTime = new Date(frame.absoluteObservationTime).getTime();
if (previousTime !== null && currentTime < previousTime) {
outOfOrderFrames.push({
index: idx,
frameIndex: frame.frameIndex,
cacheFolder: frame.cacheFolderName,
minutesAgo: frame.minutesAgo,
observationTime: frame.observationTime
absoluteTime: frame.absoluteObservationTime,
previousTime: new Date(previousTime).toISOString(),
timeDiffMinutes: (currentTime - previousTime) / 1000 / 60
});
}
previousTime = currentTime;
});
if (outOfOrderFrames.length > 0) {
@@ -1257,6 +1262,10 @@
});
}
// Use only valid frames going forward
allFrames.length = 0;
allFrames.push(...validFrames);
// Re-index frames sequentially for display
allFrames.forEach((frame, idx) => {
frame.sequentialIndex = idx;
@@ -1988,10 +1997,9 @@
// Update time display
const timeDisplay = document.getElementById('current-frame-time');
if (timeDisplay) {
if (isExtendedMode && frame.absoluteObservationTime) {
timeDisplay.textContent = formatDate(frame.absoluteObservationTime);
} else if (frame.minutesAgo !== undefined) {
timeDisplay.textContent = `${frame.minutesAgo} min ago`;
if (frame.absoluteObservationTime) {
const minutesAgo = Math.round((Date.now() - new Date(frame.absoluteObservationTime).getTime()) / 60000);
timeDisplay.textContent = `${minutesAgo} min ago`;
} else {
timeDisplay.textContent = '-';
}
@@ -2075,7 +2083,10 @@
: (frame.cacheTimestamp ? formatDate(frame.cacheTimestamp) : '');
altText = `Radar frame ${frameNum}${timeInfo ? ' (' + timeInfo + ')' : ''}`;
} else {
altText = `Radar frame ${frame.frameIndex} (${frame.minutesAgo} minutes ago)`;
const minutesAgo = frame.absoluteObservationTime
? Math.round((Date.now() - new Date(frame.absoluteObservationTime).getTime()) / 60000)
: null;
altText = `Radar frame ${frame.frameIndex}${minutesAgo !== null ? ` (${minutesAgo} minutes ago)` : ''}`;
}
// Check if image is already loaded (from preload)
@@ -2103,8 +2114,11 @@
document.getElementById('frame-info').textContent =
`Frame ${frameNum} of ${frames.length - 1}${timeInfo ? ' • ' + timeInfo : ''}`;
} else {
const minutesAgo = frame.absoluteObservationTime
? Math.round((Date.now() - new Date(frame.absoluteObservationTime).getTime()) / 60000)
: null;
document.getElementById('frame-info').textContent =
`Frame ${frame.frameIndex} of ${frames.length - 1} • ${frame.minutesAgo} minutes ago`;
`Frame ${frame.frameIndex} of ${frames.length - 1}${minutesAgo !== null ? ` • ${minutesAgo} minutes ago` : ''}`;
}
}