logging: compile out LOG_TRACE by default, demote chatty DEBUG lines, drop redundant logs (#11391)

* logging: gate LOG_TRACE behind MESHTASTIC_TRACE_LOGGING, drop redundant reclock logs

LOG_TRACE now compiles out by default so trace-level diagnostics cost no
flash; enable with -DMESHTASTIC_TRACE_LOGGING. Portduino keeps it on for
the traceFilename packet-trace feature.

Remove the 66 caller-side I2C reclock/restore log lines in the telemetry
sensors: ReClockI2C::setClock/restoreClock already log both frequencies
internally (now at trace level, since they fire every sensor read).

Also unify near-duplicate literals (colon/case/punctuation variants) so
linker string dedup applies, and drop an information-free bare 'done'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* logging: demote chatty per-packet/per-poll DEBUG lines to trace level

With LOG_TRACE compiled out by default, per-iteration chatter (packet
bookkeeping, sensor poll values, e-ink refresh reasons, GPS pin states,
UI runState traces) now costs no flash on device builds while remaining
one -DMESHTASTIC_TRACE_LOGGING away. 108 lines demoted, 4 information-
free lines removed; failure paths, drop reasons, and one-time init logs
all stay at debug level.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* logging: address CodeRabbit review on trace-gate PR

- GPS: pass serial-derived buffers as %s args, never as format strings
  (untrusted bytes could contain % directives)
- 0x%08x for packet id / NodeNum per convention (Router, CannedMessage,
  NeighborInfo); unsigned casts for size_t args; %u for uint32_t delta
- EInk: async full-refresh begin/complete back to DEBUG (rare state
  transitions); per-frame SKIPPED lines stay trace

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* logging: gate trace on the flag's value, not its presence

-DMESHTASTIC_TRACE_LOGGING=0 previously *enabled* trace logging because
the gate tested definedness. The flag now defaults per-platform
(portduino 1, else 0) and both backends test the value, so =0 disables,
=1 or a bare -D enables. Also cast tx_after-millis() to uint32_t for %u
(millis() is unsigned long on native).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* logging: clang-format rewrap after specifier widening

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* Even fewer bytes!

* logging: keep compile-gated debug lines at debug level; fix native-suite-count

Lines already inside default-off #ifdef blocks (GPS_DEBUG,
DEBUG_LOOP_TIMING) cost no flash and should stay visible at debug level
when their gate is enabled, rather than also requiring
MESHTASTIC_TRACE_LOGGING.

test/native-suite-count lags the two test_event_channel_* suites added
by #11045 (develop's Native Suite Count check has the same mismatch);
bump 46 -> 47.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

* gps: route GPS_DEBUG diagnostics through a LOG_DEBUG_GPS() macro (#11414)

Replaces 27 log-only #ifdef GPS_DEBUG blocks across GPS.cpp,
PositionModule, MeshService, and GPSStatus.h with a single-line
LOG_DEBUG_GPS() call (src/gps/GPSLog.h, modeled on LOG_MIGRATION:
value-gated, ((void)0) when off). Blocks containing declarations,
control flow, hexDump, or nested conditionals keep an explicit
'#if GPS_DEBUG' guard. RTC.cpp's per-reading raw time dumps and
per-candidate rejection chatter fold under the same gate; quality
transitions and boot-time seeding stay at debug.

Also fixes the '// define GPS_DEBUG' missing-# typo in two variant
headers and updates all seven commented examples to the value form
('#define GPS_DEBUG 1') required by the value-based gate.


Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

Co-authored-by: Claude <noreply@anthropic.com>

* gps: declare RTC gmtime result as pointer to const (cppcheck)

With the setTime debug dump gated behind GPS_DEBUG, all remaining uses
of t are reads; cppcheck (constVariablePointer) now flags it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1

---------

Co-authored-by: Claude <noreply@anthropic.com>

variants/esp32/chatter2/variant.h

@@ -5,7 +5,7 @@
 //////////////////////////////////////////////////////////////////////////////////
 
 // Debugging
-// #define GPS_DEBUG
+// #define GPS_DEBUG 1
 
 // Lora
 #define USE_LLCC68 // Original Chatter2 with LLCC68 module

variants/esp32/tbeam/variant.h

@@ -43,7 +43,7 @@
 #define GPS_UBLOX
 #define GPS_RX_PIN 34
 #define GPS_TX_PIN 12
-// #define GPS_DEBUG
+// #define GPS_DEBUG 1
 
 // Used when the display shield is chosen
 #ifdef USE_ST7796

variants/nrf52840/diy/nrf52_promicro_diy_tcxo/variant.h

@@ -135,7 +135,7 @@ https://github.com/brad112358/easy_E22
 #endif
 
 #define GPS_UBLOX
-// define GPS_DEBUG
+// #define GPS_DEBUG 1
 
 // UART interfaces
 #define PIN_SERIAL1_TX GPS_TX_PIN

variants/nrf52840/dls_Minimesh_Lite/variant.h

@@ -57,7 +57,7 @@ extern "C" {
 
 #define PIN_GPS_EN (0 + 24)
 #define GPS_UBLOX
-// define GPS_DEBUG
+// #define GPS_DEBUG 1
 
 // UART interfaces
 #define PIN_SERIAL1_TX GPS_TX_PIN

variants/nrf52840/seeed_wio_tracker_L1/variant.h

@@ -129,7 +129,7 @@ static const uint8_t SCL = PIN_WIRE_SCL;
 
 #define PIN_GPS_STANDBY D0
 
-// #define GPS_DEBUG
+// #define GPS_DEBUG 1
 //  #define GPS_EN D18 // P1.05
 #endif
 

variants/nrf52840/seeed_wio_tracker_L1_eink/variant.h

@@ -137,7 +137,7 @@ static const uint8_t SCL = PIN_WIRE_SCL;
 
 #define PIN_GPS_STANDBY D0
 
-// #define GPS_DEBUG
+// #define GPS_DEBUG 1
 //  #define GPS_EN D18 // P1.05
 #endif
 

variants/nrf52840/t-echo-lite/variant.h

@@ -131,7 +131,7 @@ static const uint8_t A0 = PIN_A0;
 #define PIN_SPI1_SCK PIN_EINK_SCLK
 
 // GPS pins
-// #define GPS_DEBUG
+// #define GPS_DEBUG 1
 #define GPS_L76K
 #define GPS_BAUDRATE 9600
 #define HAS_GPS 1