Null-check reply allocations in allocErrorResponse and RemoteHardware (#11260)

allocAckNak returns nullptr when the packet pool is exhausted, but allocErrorResponse passed the result straight to setReplyTo, which dereferences it. Reachable unauthenticated: an ADMIN_APP packet on a known-key channel takes the NOT_AUTHORIZED path, so a flood that empties the pool crashes the node. MemoryDynamic::alloc no longer aborting on failure made this reachable on PSRAM, STM32WL and Portduino targets. Callers already treat a null reply as no response. Same fix for the two RemoteHardwareModule sites.
This commit is contained in:
Thomas Göttgens
2026-07-27 14:54:57 -04:00
committed by GitHub
parent ae16c052d5
commit 80f972655d
2 changed files with 8 additions and 3 deletions
+2
View File
@@ -87,6 +87,8 @@ meshtastic_MeshPacket *MeshModule::allocErrorResponse(meshtastic_Routing_Error e
uint8_t channelIndex =
p->which_payload_variant == meshtastic_MeshPacket_decoded_tag ? p->channel : channels.getPrimaryIndex();
auto r = allocAckNak(err, getFrom(p), p->id, channelIndex);
if (!r) // pool exhausted; callers treat a null reply as "no response"
return nullptr;
setReplyTo(r, *p);