From 854eae456b597d4871948cd51d1ffb20d7682875 Mon Sep 17 00:00:00 2001 From: Austin Date: Sat, 1 Aug 2026 19:13:22 -0400 Subject: [PATCH] QMA6100PSingleton constructor fix pio check warnings (#11313) Fixes cppcheck issues src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::rawAccelData' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar] src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::_i2cPort' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar] src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::_deviceAddress' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar] --- src/motion/QMA6100PSensor.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/motion/QMA6100PSensor.cpp b/src/motion/QMA6100PSensor.cpp index 151444fd8..020a73a4d 100644 --- a/src/motion/QMA6100PSensor.cpp +++ b/src/motion/QMA6100PSensor.cpp @@ -170,7 +170,13 @@ QMA6100PSingleton *QMA6100PSingleton::GetInstance() return pinstance; } -QMA6100PSingleton::QMA6100PSingleton() {} +// The QMA6100P library leaves these base class members uninitialised until begin() runs +QMA6100PSingleton::QMA6100PSingleton() +{ + rawAccelData = {0, 0, 0}; + _i2cPort = nullptr; + _deviceAddress = 0; +} QMA6100PSingleton::~QMA6100PSingleton() {}