From 95bbb38b667c4b6a3ece550e558a6d3e75a56d19 Mon Sep 17 00:00:00 2001 From: Ben Meadors Date: Wed, 8 Apr 2026 14:18:18 -0500 Subject: [PATCH] Fix buffer overflow in allocAtakPli by ensuring null termination for callsigns --- src/modules/PositionModule.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/modules/PositionModule.cpp b/src/modules/PositionModule.cpp index dd98ba7e4..8a0d6ab1d 100644 --- a/src/modules/PositionModule.cpp +++ b/src/modules/PositionModule.cpp @@ -334,7 +334,9 @@ meshtastic_MeshPacket *PositionModule::allocAtakPli() // Callsign - stored as plain string (no compression, apps handle that) strncpy(takPacket.callsign, owner.long_name, sizeof(takPacket.callsign) - 1); + takPacket.callsign[sizeof(takPacket.callsign) - 1] = '\0'; strncpy(takPacket.device_callsign, owner.long_name, sizeof(takPacket.device_callsign) - 1); + takPacket.device_callsign[sizeof(takPacket.device_callsign) - 1] = '\0'; // Encode TAKPacketV2 protobuf, leaving room for flags byte prefix uint8_t protobuf_bytes[sizeof(mp->decoded.payload.bytes) - 1];