ElixirForge/firmware
1
0
Fork 0
mirror of https://github.com/alexhopeoconnor/firmware.git synced 2026-10-22 11:17:49 +10:00
Code Releases Activity

Fix backwards GPS_RX_PIN/GPS_TX_PIN direction comments (#11585)

Browse Source 
GPS.cpp passes GPS_RX_PIN as the MCU's RX pin and GPS_TX_PIN as its TX
pin. Nine variants documented the opposite, which reads as if the pins
were swapped on working hardware (see #11584).

Comment-only change; no pin assignment is touched.
This commit is contained in:
Thomas Göttgens
2026-08-24 11:29:54 +02:00
committed by GitHub
parent 0271be9369
commit ee48094ea8
9 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
variants/nrf52840/heltec_mesh_node_t096/variant.h
+2 -2
View File
@@ -161,8 +161,8 @@ No longer populated on PCB
#define GPS_EN_ACTIVE LOW
#define PERIPHERAL_WARMUP_MS 1000 // Make sure I2C QuickLink has stable power before continuing
#define PIN_GPS_PPS (32 + 11)
#define GPS_TX_PIN (0 + 25) // This is for bits going TOWARDS the CPU
#define GPS_RX_PIN (0 + 23) // This is for bits going TOWARDS the GPS
#define GPS_TX_PIN (0 + 25) // This is for bits going TOWARDS the GPS
#define GPS_RX_PIN (0 + 23) // This is for bits going TOWARDS the CPU
#define GPS_THREAD_INTERVAL 50