mirror of
https://github.com/alexhopeoconnor/firmware.git
synced 2026-10-04 03:18:10 +10:00
* test: make every suite run its own binary, and fail the run when it does not PlatformIO links every native test program to the one $BUILD_DIR/$PROGNAME path and attributes Unity output by text alone, never checking that the source file a case came from belongs to the suite it thinks it ran. Both harnesses had been split into a build pass (--without-testing) and a run pass (--without-building), and for a non-embedded platform the run pass never relinks - so all 57 suites executed whichever suite was linked last, each reporting PASSED under its own name. Introduced for CI in4906f8a6and for bin/run-tests.sh in de6b2319; both ran fused, and correctly, before that. Drop --without-building from both run passes. The --without-testing pass stays as a warm-up so no single suite absorbs the whole src compile in its reported duration; with the objects already cached the per-suite step is one test_main.cpp plus a link. Add bin/check-test-attribution.py, which grades the JUnit reports both harnesses already produce. It fails on a test case whose source file lies outside the suite that reported it, and on a suite that was asked to run and produced no cases at all. Wired in three places: bin/run-tests.sh as a RED verdict ahead of the softer ones, per area in CI so a mismatch names its area, and once over the merged report so an area that never executed cannot hide. Suite ownership is matched on whole path segments, so test_mesh does not claim test_mesh_module, and the -f pattern is resolved against the canonical set rather than taken as a literal suite name. * fix(test): pin simradio off for the packet-signing PKI cases [env:coverage] passes -s to the test binary (74e6723ad, #8251), which sets portduino_config.force_simradio. wouldEncryptWithPKC() lists !force_simradio among its preconditions, so perhapsEncode() takes the channel-crypto branch, returns NONE and leaves pki_encrypted false - failing test_B11_normal_unicast_still_uses_pki and test_B12_licensed_receiver_does_not_decrypt_pki, both of which assert the production PKI path. [env:native] passes no such flag, which is the whole of the long-standing "passes under native, fails under coverage" split; it was never gcov, ASan or a host. Save and clear the flag in setUp, restore it in tearDown, so the suite asserts the encode path it is named for under either env's invocation. Same binary, pristine $HOME: 77 tests 0 failures with -s and without, where before -s gave 2 failures. Whether the unit-test binary should run with -s at all is a separate question - it means CI exercises the simradio configuration for every suite - and is left alone here. * fix(router): drive the admin-key fallback budget from the injectable clock The budget is 8 tokens refilling one per 250ms of wall clock, and test_admin_key_fallback_is_rate_limited drains it with eight PKI decodes before asserting the ninth is refused. That gives the drain loop 31ms per iteration, each of which generates a keypair and does three X25519 operations under gcov and ASan. This box runs them in ~4ms; a GitHub runner takes ~38ms, so a token refills mid-drain and the packet the test expects to be blocked decodes. Measured from both runs' own log timestamps, 9.5x apart. Read the bucket through Time::getMillis() instead of millis(), and have the test set and advance the virtual clock rather than sleeping. The subtraction was already wrap-correct, so the deadline guard is unaffected. Restores the clock in tearDown so the rest of the suite is untouched, and drops ~3s of real sleeping from the run. * test: declare the event-channel suites' shared state Both construct a NodeDB, whose constructor persists a default set into an empty prefs directory, so each writes the five prefs protos. Neither was declared, because until suites started running their own binaries nothing had ever observed them writing anything. * test: add a repeat runner for order-independent flakes A single green run says nothing about a real-time race or a slow-host margin: the rate-limit budget above passes here with 7x headroom and still fails on a CI runner. Run one suite N times against a fresh scratch $HOME each time, optionally against CPU contention, and print a flake rate. Failing runs keep their log and their sandbox; passing runs leave nothing. Simradio is taken from the env's own test_testing_command, so a stress run reproduces the real invocation rather than inventing a third one. * fix(test): keep a native test run off the host's radio bin/pio-test-isolate.sh sandboxes $HOME, but portduinoSetup() looks for config in ./config.yaml and /etc/meshtasticd/config.yaml - the second absolute, so no $HOME sandbox can hide it. On a machine running meshtasticd that config selects the real LoRa module and the run continues into GPIO and SPI setup, so ./bin/run-tests.sh -e native would drive the developer's own radio without saying so. -e native is also the faster of the two, and the one reached for when iterating. [env:coverage] already passes -s, which short-circuits ahead of the config search and returns before hardware init. Pass it for [env:native] too. That closes the hazard and, incidentally, makes the two envs invoke the binary identically - they did not, which is the whole of the long-standing "green locally, red in CI" split. * test: run every suite with PKC on, and assert it stays that way force_simradio does two unrelated jobs. It keeps portduinoSetup() off the host's hardware, which every test run wants, and it makes wouldEncryptWithPKC() return false, which no test run wants: the encode path under test then falls back to channel crypto and any case asserting PKI fails, or worse, passes while asserting the wrong thing. Three suites had each worked this out separately and cleared the flag themselves - test_admin_session_repro's comment describes the mechanism exactly. Clear it once in initializeTestEnvironment() instead. By then portduinoSetup() has already skipped the config search and chosen the simulated radio, and it never reconsults the flag, so clearing it cannot bring hardware back; the only remaining readers are the PKC gate and an exit_simulator intercept no test can reach. The per-suite copy added to test_packet_signing for B11/B12 goes away with it. Two asserts, because both invariants were true only by inspection: - No listening sockets. main.cpp's setup()/loop() are compiled out under PIO_UNIT_TESTING, so the phone API, MQTT and the web server never start - but nothing checked. A suite that pulled in a service binding a port would open one on the developer's machine for the length of the run. - force_simradio still clear, before every test rather than once per suite, since a case that restores a struct it snapshotted earlier puts it back and silently disables PKC for everything after it. Named per test, so the report points at the case after the culprit. Both exit rather than TEST_FAIL: they run outside a Unity test frame, and silently repairing either one would leave the suite that broke it passing. Verified by disabling the clear and watching the guard fire on the first case instead of reporting two quiet failures. * test: let the repeat runner vary suite order too Repeating one binary finds races and slow-host margins; it cannot find state that leaks from one suite into the next, because only one suite runs. --shuffle drives run-tests.sh --seed with a fresh seed each iteration and reports which seeds went red, so the shuffle already in the harness yields a flake rate rather than a single sample. Seeds are printed and replayable. * fix(test): baseline the environment from whichever runs first Clearing force_simradio in initializeTestEnvironment() missed the suites that never call it. test_atak is one, and it also pulls in TestUtil.h, so it got the per-test assert without ever getting the baseline and aborted on its first case - caught by CI, which is what the assert is for. test_geocoord_distance, test_meshpacket_serializer and test_utf8 skip the init too, but include no TestUtil.h at all, so nothing reached them either way. Move the clear and the socket check into baselineEnvironment(), called from initializeTestEnvironment() or from the first RUN_TEST, whichever comes first. Suites that initialise are still asserted from their first case; the rest are baselined at case one and asserted from case two. Print the violation on stdout as well as stderr: bin/run-tests.sh filters the program's stderr, so locally the message vanished and the run reported "exit-time abort (likely sanitizer)" - the exit code read as a signal number again, with no sign of the real reason. * test: drop the per-suite simradio exceptions Three suites had each found that force_simradio disables PKC and cleared it themselves. initializeTestEnvironment() now clears it once for every suite, so all six sites are dead code - along with the PortduinoGlue.h include each pulled in for it. test_event_channel_router's is the one worth removing rather than leaving: it snapshotted the flag into SavedGlobals and restored it at teardown, which is exactly the shape the per-test assert exists to catch. Harmless while the snapshot reads false, and a silent PKC-off for every later case if that ever changed. The three suites pass unchanged: 54 cases, attribution clean. * test: tell a deliberate harness abort from a sanitizer fault A guard in TestUtil.cpp that aborts on purpose - a listening socket, or force_simradio put back - exits non-zero with no sanitizer report, so it fell through to the exit-time-abort heuristic and was announced as "RED exit-time abort (tests passed; likely sanitizer)". That is the same trap as the phantom SIGILL two checks above: a verdict line naming a cause it has not established, sending the reader after a memory bug that does not exist. It cost hours in the original investigation and it cost the first read of a test_atak failure today. Match the FATAL line the guards print on stdout for exactly this purpose, and report the reason they gave instead of guessing. * test: say why three suites omit TestUtil.h They are pure-function - no NodeDB, no router, no sockets, no PKC - so the harness-wide guards in TestUtil.h would assert conditions they cannot reach, and initializeTestEnvironment()'s RTC and OSThread setup would pull in portduino globals they otherwise never touch. Suite-level state cleanliness still applies: bin/pio-test-isolate.sh fingerprints the sandbox from outside and wraps every suite regardless. Recorded at the top of each so the omission reads as a decision rather than an oversight - it looked like the latter when the socket and simradio asserts landed. * test(traffic): give every case a primary channel resetTrafficConfig() zeroed channelFile and left channels_count at 0, so the 66 cases that do not install a channel themselves ran against a device with none. Every router lookup then hit Channels::getByIndex()'s out-of-range branch and logged, which is 12106 of the suite's 20088 ERROR lines and tests nothing - a real device always has a primary channel, and no case here asserts channels-unset behaviour. Install the well-known primary the suite already builds for its precision cases. All 85 pass unchanged, and the suite's ERROR output drops to 7985, the remainder being decode failures from test_tm_fuzz_nodenum_blitz's malformed payloads. * test: budget each suite's LOG_ERROR output A suite can pass while emitting six figures of ERROR, which buries a real failure and trains everyone to skim. Count them per suite and grade the count as a second axis, alongside the CLEAN/DIRTY verdict already computed from the same captured log. Declared in the same manifest, as a RANGE rather than a ceiling, because for a fuzz suite the floor is the half that matters: test_fuzz_decode logging ~100k rejections is the suite working, and the same suite logging none means it stopped feeding malformed input while every case still passes. Bounds are wide on purpose - they catch a path that has stopped running, not a drift of a few hundred lines. Undeclared suites get 100, which 50 of 57 already meet. AMBER, not RED. Three log sites - mesh-pb-constants.cpp:28, Channels.cpp:356, MQTT.cpp:92 - account for nearly all the remaining volume, and landing this red before they are demoted would buy exemptions rather than fixes. * test: canary the attribution check, and run the state self-test in CI check-test-attribution.py guards against the false green, and nothing guarded the guard. A checker that has quietly stopped matching looks exactly like a codebase with no problem, which is how the original went unnoticed for three weeks of green runs. The canary reproduces the failure deliberately - two suites run with --without-building, so PlatformIO does not relink and both execute the same leftover binary - and requires the checker to catch it. It also fails if the reproduction stops reproducing: if PlatformIO ever relinks per suite under that flag, the reason both harnesses stopped passing it no longer holds, and the harness should be revisited rather than left on a stale assumption. bin/test-state-check.sh already existed with fixtures asserting CLEAN/CLEAN/DIRTY/MISSING and had never run in CI. Wire it in too - the shared-state checker had the same blind spot, and somebody had already written the test for it. * fix(ci): run the attribution canary where it cannot clobber the daemon The canary relinks $BUILD_DIR/$PROGNAME, and in simulator-tests that replaced the daemon binary with a test suite. The integration test then started it and waited for a listening socket, which a test binary never opens - by assertion, since initializeTestEnvironment() now fails a suite that holds one - so the step sat until its 20s timeout and the job exited 124. The canary itself had already passed. Move it to platformio-tests, where the binary is per-suite already and nothing downstream needs the daemon, and place it after the coverage capture so its extra runs stay out of the numbers. The shared-state self-test stays in simulator-tests; it touches no binary. Fitting failure mode for this branch: one shared program path, two consumers, and the second one silently getting the first one's build. * fix(ci): silence the XXE rule on the attribution checker semgrep blocks xml.etree.ElementTree.parse as XXE-prone. The input here is the JUnit report PlatformIO wrote moments earlier in the same run, and anything able to plant a hostile report is already executing its own code in that job, so parsing it defused changes nothing it could do. defusedxml is in the tree but only under bin/bump_metainfo with its own requirements, and pulling it onto this path would add an install step to every native test job for no reachable threat. Suppressed with a reason at the call site, the same shape as the subprocess-shell-true suppression in extra_scripts/nrf54l15_linker.py. * fix(test): address the review findings on the harness guards Two were real defects rather than style: - state_count_errors() returned "0\n0" for a log with no ERROR lines, because grep -c prints 0 and *then* exits 1, so the `|| printf 0` fallback appended a second one. The classifier threw a syntax error on it. Dormant only because every suite currently emits at least one ERROR line; the planned log-level demotions would have driven most suites to zero and tripped it everywhere, looking like the demotions broke the harness. - check-test-attribution.py returned OK for a report whose cases carry no `file` attribute. It cannot prove ownership in that state, so a changed JUnit format would have restored the exact false green it exists to catch. Now its own finding, listed and fatal. The rest: keep the sandbox when an error budget is breached, since that is the one outcome whose evidence was being deleted; reject a missing or non-numeric option value in stress-suite.sh instead of running an empty loop and reporting 0/0 as a pass; exit on INT/TERM rather than cleaning up and carrying on; drive repetitions through pio-test-isolate.sh so a stress run exercises the real invocation; require the canary to see MISATTRIBUTED rather than any non-zero exit, so an unreadable report cannot read as a caught mismatch; and check for listening sockets before every test, since a listener would be opened by the code under test. resetAdminKeyFallbackBudget() is a new PIO_UNIT_TESTING hook, shaped like the neighbouring resetRoutingAuthEvaluationCount(). The refill stamp is only meaningful against the clock that produced it, so a suite switching timebases leaves a stamp from the other one and the next unsigned subtraction reads as a near-infinite gap - silently refilling the bucket. Also move the semgrep marker onto its own line: buried mid-sentence in a comment it was ignored, and the XXE finding stayed blocking.
304 lines
13 KiB
C++
304 lines
13 KiB
C++
#pragma once
|
|
|
|
#include "Channels.h"
|
|
#include "MemoryPool.h"
|
|
#include "MeshTypes.h"
|
|
#include "Observer.h"
|
|
#include "PacketHistory.h"
|
|
#include "PointerQueue.h"
|
|
#include "RadioInterface.h"
|
|
#include "concurrency/LockGuard.h"
|
|
#include "concurrency/OSThread.h"
|
|
#include <memory>
|
|
|
|
inline bool isCoordinatePortnum(meshtastic_PortNum portnum)
|
|
{
|
|
return portnum == meshtastic_PortNum_POSITION_APP || portnum == meshtastic_PortNum_WAYPOINT_APP ||
|
|
portnum == meshtastic_PortNum_MAP_REPORT_APP;
|
|
}
|
|
|
|
bool isBlockedEventCoordinatePacket(const meshtastic_MeshPacket *p);
|
|
bool willUsePki(const meshtastic_MeshPacket *p);
|
|
|
|
/// rx_time/has_rx_time for "now": a real epoch when the clock is trustworthy, else a
|
|
/// Time::getUptimeSecs() placeholder with valid=false. Uptime seconds are monotonic, so
|
|
/// reconciliation against a later epoch is exact at any age.
|
|
struct RxTimeStamp {
|
|
uint32_t time;
|
|
bool valid;
|
|
};
|
|
RxTimeStamp computeRxTimeStamp();
|
|
|
|
/// Stamp p->rx_time/p->has_rx_time with computeRxTimeStamp().
|
|
void stampRxTime(meshtastic_MeshPacket *p);
|
|
|
|
/**
|
|
* A mesh aware router that supports multiple interfaces.
|
|
*/
|
|
class Router : protected concurrency::OSThread, protected PacketHistory
|
|
{
|
|
private:
|
|
/// Packets which have just arrived from the radio, ready to be processed by this service and possibly
|
|
/// forwarded to the phone.
|
|
PointerQueue<meshtastic_MeshPacket> fromRadioQueue;
|
|
|
|
protected:
|
|
std::unique_ptr<RadioInterface> iface = nullptr;
|
|
|
|
public:
|
|
/**
|
|
* Constructor
|
|
*
|
|
*/
|
|
Router();
|
|
|
|
/**
|
|
* Currently we only allow one interface, that may change in the future
|
|
*/
|
|
void addInterface(std::unique_ptr<RadioInterface> _iface) { iface = std::move(_iface); }
|
|
|
|
/**
|
|
* Borrowed (non-owning) access to the radio interface - used by NodeDB
|
|
* after a lockdown unlock so it can push the freshly-loaded config to
|
|
* the SX12xx via reconfigure(). Returns nullptr when no radio has been
|
|
* attached (e.g. ARCH_PORTDUINO simulator before SimRadio bind).
|
|
*/
|
|
RadioInterface *getRadioIface() { return iface.get(); }
|
|
|
|
/**
|
|
* do idle processing
|
|
* Mostly looking in our incoming rxPacket queue and calling handleReceived.
|
|
*/
|
|
virtual int32_t runOnce() override;
|
|
|
|
/**
|
|
* Works like send, but if we are sending to the local node, we directly put the message in the receive queue.
|
|
* This is the primary method used for sending packets, because it handles both the remote and local cases.
|
|
*
|
|
* NOTE: This method will free the provided packet (even if we return an error code)
|
|
*/
|
|
ErrorCode sendLocal(meshtastic_MeshPacket *p, RxSource src = RX_SRC_RADIO);
|
|
|
|
/** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */
|
|
bool cancelSending(NodeNum from, PacketId id);
|
|
|
|
/** Attempt to find a packet in the TxQueue. Returns true if the packet was found. */
|
|
bool findInTxQueue(NodeNum from, PacketId id);
|
|
|
|
/** Allocate and return a meshpacket which defaults as send to broadcast from the current node.
|
|
* The returned packet is guaranteed to have a unique packet ID already assigned
|
|
*/
|
|
[[nodiscard]] meshtastic_MeshPacket *allocForSending();
|
|
|
|
/** Return Underlying interface's TX queue status */
|
|
[[nodiscard]] meshtastic_QueueStatus getQueueStatus();
|
|
|
|
/**
|
|
* @return our local nodenum */
|
|
[[nodiscard]] NodeNum getNodeNum();
|
|
|
|
/** Wake up the router thread ASAP, because we just queued a message for it.
|
|
* FIXME, this is kinda a hack because we don't have a nice way yet to say 'wake us because we are 'blocked on this queue'
|
|
*/
|
|
void setReceivedMessage();
|
|
|
|
/**
|
|
* RadioInterface calls this to queue up packets that have been received from the radio. The router is now responsible for
|
|
* freeing the packet
|
|
*/
|
|
virtual void enqueueReceivedMessage(meshtastic_MeshPacket *p);
|
|
|
|
/**
|
|
* Send a packet on a suitable interface. This routine will
|
|
* later free() the packet to pool. This routine is not allowed to stall.
|
|
* If the txmit queue is full it might return an error
|
|
*
|
|
* NOTE: This method will free the provided packet (even if we return an error code)
|
|
*/
|
|
virtual ErrorCode send(meshtastic_MeshPacket *p);
|
|
|
|
/* Statistics for the amount of duplicate received packets and the amount of times we cancel a relay because someone did it
|
|
before us */
|
|
uint32_t rxDupe = 0, txRelayCanceled = 0;
|
|
|
|
protected:
|
|
friend class RoutingModule;
|
|
|
|
/**
|
|
* Should this incoming filter be dropped?
|
|
*
|
|
* FIXME, move this into the new RoutingModule and do the filtering there using the regular module logic
|
|
*
|
|
* Called immediately on reception, before any further processing.
|
|
* @return true to abandon the packet
|
|
*/
|
|
virtual bool shouldFilterReceived(const meshtastic_MeshPacket *p) { return false; }
|
|
|
|
/** Relay an opaque packet without admitting it to local routing/history state. */
|
|
virtual bool relayOpaquePacket(const meshtastic_MeshPacket *) { return false; }
|
|
|
|
/**
|
|
* Generate the implicit ACK for our own transmission overheard being rebroadcast, using header
|
|
* fields only (from/id). Split out of shouldFilterReceived() so it can also run when the auth
|
|
* gate short-circuits a packet we cannot decrypt (a PKI DM we originated is opaque to us, so
|
|
* without this the client never sees "Delivered to mesh" for DMs).
|
|
*/
|
|
virtual void perhapsGenerateImplicitAckForOwnOverheard(const meshtastic_MeshPacket *) {}
|
|
|
|
/**
|
|
* Determine if hop_limit should be decremented for a relay operation.
|
|
* Returns false (preserve hop_limit) only if all conditions are met:
|
|
* - It's NOT the first hop (first hop must always decrement)
|
|
* - Local device is a ROUTER, ROUTER_LATE, or CLIENT_BASE
|
|
* - Previous relay is a favorite ROUTER, ROUTER_LATE, or CLIENT_BASE
|
|
*
|
|
* @param p The packet being relayed
|
|
* @return true if hop_limit should be decremented, false to preserve it
|
|
*/
|
|
bool shouldDecrementHopLimit(const meshtastic_MeshPacket *p);
|
|
|
|
/**
|
|
* Every (non duplicate) packet this node receives will be passed through this method. This allows subclasses to
|
|
* update routing tables etc... based on what we overhear (even for messages not destined to our node)
|
|
*/
|
|
virtual void sniffReceived(const meshtastic_MeshPacket *p, const meshtastic_Routing *c);
|
|
|
|
/**
|
|
* Send an ack or a nak packet back towards whoever sent idFrom
|
|
*/
|
|
void sendAckNak(meshtastic_Routing_Error err, NodeNum to, PacketId idFrom, ChannelIndex chIndex, uint8_t hopLimit = 0,
|
|
bool ackWantsAck = false);
|
|
|
|
private:
|
|
/**
|
|
* Called from loop()
|
|
* Handle any packet that is received by an interface on this node.
|
|
* Note: some packets may merely being passed through this node and will be forwarded elsewhere.
|
|
*
|
|
* Note: this packet will never be called for messages sent/generated by this node.
|
|
* Note: this method will free the provided packet.
|
|
*/
|
|
void perhapsHandleReceived(meshtastic_MeshPacket *p);
|
|
|
|
/**
|
|
* Called from perhapsHandleReceived() for radio ingress and from deliverLocal() for our own
|
|
* loopback, so p may be locally generated. Does NOT free p; the caller still owns it.
|
|
*/
|
|
void handleReceived(meshtastic_MeshPacket *p, RxSource src = RX_SRC_RADIO);
|
|
|
|
/**
|
|
* The body of handleReceived(): decode, run modules, publish to MQTT. Split out so the
|
|
* depth-guarded drain in handleReceived() can process a deferred packet without re-entering
|
|
* the drain (and without touching handleDepth) - keeping the stack flat.
|
|
*/
|
|
void dispatchReceived(meshtastic_MeshPacket *p, RxSource src);
|
|
|
|
/**
|
|
* Route a packet addressed to us (or a local broadcast we loop back) into handleReceived().
|
|
* Called synchronously at the top level, but if a module sends this from inside callModules()
|
|
* (handleDepth > 0) the packet is copied into the deferred queue instead, so we never stack a
|
|
* second handleReceived() on top of a module handler - that nesting is what overflows the
|
|
* nRF52 task stack on a config save. Does not consume p; the caller's existing free path is
|
|
* unchanged.
|
|
*/
|
|
void deliverLocal(meshtastic_MeshPacket *p, RxSource src);
|
|
|
|
/// Depth of handleReceived() frames currently on the stack. >0 means a module is dispatching,
|
|
/// so a locally-sent loopback packet must be deferred rather than handled synchronously.
|
|
uint8_t handleDepth = 0;
|
|
|
|
/// Guards handleDepth and the deferred ring below. nRF52 drives the router from the BLE task as
|
|
/// well as the loop task, so both are read-modify-written from two tasks.
|
|
concurrency::Lock deferredLock;
|
|
|
|
/// A local loopback packet whose handleReceived() was deferred because it was produced from
|
|
/// inside callModules(). The queue owns the packet; its RxSource travels with it so the drain
|
|
/// dispatches it with the origin the sender intended (RX_SRC_LOCAL stays local).
|
|
struct DeferredLocal {
|
|
meshtastic_MeshPacket *p;
|
|
RxSource src;
|
|
};
|
|
|
|
/// Fixed, small ring buffer of deferred local packets. A config save fans out only a few
|
|
/// loopback packets (a self-addressed reply plus a nodeinfo/config broadcast or two), so four
|
|
/// slots cover the realistic nesting. On overflow the deferral is dropped (the packet still
|
|
/// followed its normal non-loopback path) rather than blocking or growing the heap.
|
|
static constexpr uint8_t deferredLocalCapacity = 4;
|
|
DeferredLocal deferredLocalQueue[deferredLocalCapacity];
|
|
uint8_t deferredLocalHead = 0; // index of the oldest queued entry
|
|
uint8_t deferredLocalCount = 0; // entries currently queued
|
|
|
|
/// Queue a deferred local packet. Returns false (and queues nothing) when full.
|
|
/// Caller must hold deferredLock: the enqueue decision is atomic with the drain's depth update.
|
|
bool enqueueDeferredLocal(meshtastic_MeshPacket *p, RxSource src);
|
|
/// Pop the oldest deferred local packet into out. Returns false when empty.
|
|
/// Caller must hold deferredLock.
|
|
bool dequeueDeferredLocal(DeferredLocal &out);
|
|
|
|
/** Frees the provided packet, and generates a NAK indicating the specifed error while sending */
|
|
void abortSendAndNak(meshtastic_Routing_Error err, meshtastic_MeshPacket *p);
|
|
|
|
#ifdef PIO_UNIT_TESTING
|
|
public:
|
|
/// High-water mark of handleDepth across this Router's life. The deferral must keep it at 1:
|
|
/// a nested local send may never re-enter handleReceived() synchronously.
|
|
uint8_t maxHandleDepthObserved = 0;
|
|
/// Count of deferrals dropped because the queue was full or a copy could not be allocated.
|
|
uint32_t deferredLocalDropped = 0;
|
|
/// Number of deferred local packets currently queued.
|
|
uint8_t deferredLocalPending() const { return deferredLocalCount; }
|
|
#endif
|
|
};
|
|
|
|
enum DecodeState { DECODE_SUCCESS, DECODE_FAILURE, DECODE_OPAQUE, DECODE_FATAL, DECODE_POLICY_REJECT };
|
|
enum class RoutingAuthVerdict { ACCEPT, OPAQUE_RELAY_ONLY, REJECT };
|
|
|
|
/** FIXME - move this into a mesh packet class
|
|
* Remove any encryption and decode the protobufs inside this packet (if necessary).
|
|
*
|
|
* @return true for success, false for corrupt packet.
|
|
*/
|
|
DecodeState perhapsDecode(meshtastic_MeshPacket *p);
|
|
|
|
/** Apply receive authentication before routing state mutation; unknown-channel packets may remain opaque relay-only. */
|
|
RoutingAuthVerdict passesRoutingAuthGate(meshtastic_MeshPacket *p);
|
|
#ifdef PIO_UNIT_TESTING
|
|
uint32_t routingAuthEvaluationCount();
|
|
void resetRoutingAuthEvaluationCount();
|
|
/** Refill the admin-key fallback budget and re-stamp it against the clock in use right now. */
|
|
void resetAdminKeyFallbackBudget();
|
|
#endif
|
|
|
|
/** Return 0 for success or a Routing_Error code for failure
|
|
*/
|
|
meshtastic_Routing_Error perhapsEncode(meshtastic_MeshPacket *p);
|
|
|
|
#if !(MESHTASTIC_EXCLUDE_PKI) && !(MESHTASTIC_EXCLUDE_XEDDSA)
|
|
/** Enforce the configured XEdDSA receive policy. The caller must hold cryptLock.
|
|
* Returns false when the packet must be dropped. */
|
|
bool checkXeddsaReceivePolicy(meshtastic_MeshPacket *p);
|
|
#endif
|
|
|
|
#if !(MESHTASTIC_EXCLUDE_PKI)
|
|
/**
|
|
* Would perhapsEncode() PKC-encrypt this outgoing packet? Callers that must know the encryption a
|
|
* packet will get before it is encoded (e.g. pinning a peer key at request time) have to ask this
|
|
* rather than inspect p, whose pki_encrypted/public_key fields are only populated on the RX path.
|
|
*
|
|
* @param chIndex the channel index p carries before encoding rewrites it to a hash.
|
|
* @param haveDestKey whether a public key for p->to was resolvable.
|
|
*/
|
|
bool wouldEncryptWithPKC(const meshtastic_MeshPacket *p, ChannelIndex chIndex, bool haveDestKey);
|
|
#endif
|
|
|
|
extern Router *router;
|
|
|
|
/// Generate a unique packet id
|
|
// FIXME, move this someplace better
|
|
PacketId generatePacketId();
|
|
|
|
#define BITFIELD_WANT_RESPONSE_SHIFT 1
|
|
#define BITFIELD_OK_TO_MQTT_SHIFT 0
|
|
#define BITFIELD_WANT_RESPONSE_MASK (1 << BITFIELD_WANT_RESPONSE_SHIFT)
|
|
#define BITFIELD_OK_TO_MQTT_MASK (1 << BITFIELD_OK_TO_MQTT_SHIFT)
|