ElixirForge/arduino-home-assistant
1
0
Fork 0
mirror of https://github.com/alexhopeoconnor/arduino-home-assistant.git synced 2026-10-04 02:48:13 +10:00
Code Releases Activity

Bugfix/maximum number of device types (#190) (#191)

Browse Source 
* added test for maximum device types

* fix max device types check
This commit is contained in:
Kostiantyn Synytsia
2024-01-30 23:59:54 +01:00
committed by GitHub
parent b86495f492
commit 252f0ab6b1
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/HAMqtt.cpp
+1 -1
View File
@@ -185,7 +185,7 @@ bool HAMqtt::isConnected() const
void HAMqtt::addDeviceType(HABaseDeviceType* deviceType)
{
if (_devicesTypesNb + 1 >= _maxDevicesTypesNb) {
if (_devicesTypesNb + 1 > _maxDevicesTypesNb) {
return;
}
tests/BaseDeviceTypeTest/BaseDeviceTypeTest.ino
+10
View File
@@ -41,6 +41,16 @@ AHA_TEST(BaseDeviceTypeTest, register_mqtt_type) {
assertEqual(&deviceType, mqtt.getDevicesTypes()[0]);
}
// TODO it would be better to place this test in HAMqtt related test. Since there is no one yet, I leave it here
AHA_TEST(BaseDeviceTypeTest, maximum_number_of_device_types) {
HADevice device(testDeviceId);
HAMqtt mqtt(nullptr, device, 1);
DummyDeviceType deviceType(AHATOFSTR(ComponentNameStr), testUniqueId);
assertEqual((uint8_t)1, mqtt.getDevicesTypesNb());
assertEqual(&deviceType, mqtt.getDevicesTypes()[0]);
}
AHA_TEST(BaseDeviceTypeTest, default_name) {
DummyDeviceType deviceType(AHATOFSTR(ComponentNameStr), testUniqueId);
assertEqual((const char*)nullptr, deviceType.getName());